Fix/allow webquery port configuration#102
Open
masonen wants to merge 2 commits into
Open
Conversation
masonen
force-pushed
the
fix/allow-webquery-port-configuration
branch
from
a691aa6 to
b85fc65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #101
The change questionable might be, to enable webquery by default with the image. But i assumed it made sense in the scope of the ticket as webquery.md in the docs folder of a teamspeak server clearly states that it is activated by default from server version 3.13.0 onwards and you are only providing images => 3.13.0 to the official repo anyways. feel free to drop this commit though you think thats not a good change.
Also, I would be happy to provide a docu change for this, could you point me to the right repo here? Is a secondary issue needed there too?